Conversation
Contributor
|
Hey @APT-KK! A couple of things: Sound size: We have a 500KB max limit. Please compress your sound to under 500KB (or replace it if needed), then push the update. README: We don't need configs/README.md updated, it's a general informative file we keep unmodified to avoid PR conflicts. Please revert those changes. Thanks! |
Contributor
Author
|
i thinks its ready to merge now , I've fixed the issues, thanks! |
Contributor
Author
Contributor
|
Hey @APT-KK! Just need one small fix, please revert the README changes. Thanks! |
Contributor
Author
|
fixed it thank you |
marceloams
previously approved these changes
Oct 21, 2025
APT-KK
dismissed
marceloams’s stale review
The merge-base changed after approval.
Contributor
|
@APT-KK Thanks for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Type of Change
Description
add jazz yaml
Related Issue
Closes #(issue number)
Changes Made
For Sound Contributions
assets/sounds/For Code Changes
console.login production code.jsextensionsScreenshots/Audio
If applicable, add screenshots or audio samples (Optional: SoundCloud, YouTube, etc.).
Checklist